XCore target: Add large code model

Richard Osborne richard at xmos.com
Thu Nov 28 13:34:44 PST 2013

Looks good to me


 #include "llvm/CodeGen/ValueTypes.h"
+#include "llvm/IR/Constants.h"
 #include "llvm/IR/CallingConv.h”

Nitpick: includes should be in lexicographic order (http://llvm.org/docs/CodingStandards.html#include-style)

On 13 Nov 2013, at 18:44, Robert Lytton <robert at xmos.com<mailto:robert at xmos.com>> wrote:


Two patches, the first is to test current implementation - prior to the second.

    XCore target: extend tests in preparation

    XCore target: Add large code model
    When using large code model:
    Global objects larger than 'CodeModelLargeSize' bytes are placed in sections named with a trailing ".large"
    The folded global address into such objects are lowered into the const pool.
    During inspection it was noted that LowerConstantPool() was using a default offset of zero.
    A fix was made, but due to only offsets of zero being generated, testing only verifies the change is not detrimental.
    Fix explicitly specified sections flags.
    We assume the size of the object queried by getSectionForConstant() is never greater than CodeModelLargeSize.
    To handle greater than CodeModelLargeSize, changes to AsmPrinter would be required.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131128/907ef2d5/attachment.html>

More information about the llvm-commits mailing list