<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
Looks good to me
<div><br>
</div>
<div>Nitpick:</div>
<div>
<div><br>
</div>
<div> #include "llvm/CodeGen/ValueTypes.h"</div>
</div>
<div>
<div>+#include "llvm/IR/Constants.h"</div>
<div> #include "llvm/IR/CallingConv.h”</div>
</div>
<div><br>
</div>
<div>Nitpick: includes should be in lexicographic order (<a href="http://llvm.org/docs/CodingStandards.html#include-style">http://llvm.org/docs/CodingStandards.html#include-style</a>)</div>
<div><br>
</div>
<div>
<div>
<div>On 13 Nov 2013, at 18:44, Robert Lytton <<a href="mailto:robert@xmos.com">robert@xmos.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div ocsi="0" fpstyle="1" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">
<div style="direction: ltr; font-family: Tahoma; font-size: 10pt;">Hi,<br>
<br>
Two patches, the first is to test current implementation - prior to the second.<br>
<br>
PatchTests:<br>
XCore target: extend tests in preparation<br>
<br>
PatchLargeCM:<br>
XCore target: Add large code model<br>
When using large code model:<br>
Global objects larger than 'CodeModelLargeSize' bytes are placed in sections named with a trailing ".large"<br>
The folded global address into such objects are lowered into the const pool.<br>
During inspection it was noted that LowerConstantPool() was using a default offset of zero.<br>
A fix was made, but due to only offsets of zero being generated, testing only verifies the change is not detrimental.<br>
Fix explicitly specified sections flags.<br>
We assume the size of the object queried by getSectionForConstant() is never greater than CodeModelLargeSize.<br>
To handle greater than CodeModelLargeSize, changes to AsmPrinter would be required.<br>
<br>
<br>
Robert<br>
<br>
</div>
<span><PatchTests></span><span><PatchLargeCM></span></div>
</blockquote>
</div>
<br>
</div>
</body>
</html>