XCore target: Add large code model

Richard Osborne richard at xmos.com
Thu Nov 28 14:00:23 PST 2013

+/// \param RemainingAdj the current SP offset from the top of the frame.
+/// \returns RemainingAdj will be updated.
+static void IfNeededExtSP(MachineBasicBlock &MBB,

I don’t think doxygen will like a \returns on a function with no return value and I would expect clang’s -Wdocumentation to warn on this as well.  I think the normal way to write this is:

/// \param [in] [out] RemainingAdj …

the same goes for the comments on IfNeededLDAWSP.

Looks fine otherwise.

On 13 Nov 2013, at 18:44, Robert Lytton <robert at xmos.com<mailto:robert at xmos.com>> wrote:


Two patches, the first is to test current implementation - prior to the second.

    XCore target: extend tests in preparation

    XCore target: Add large code model
    When using large code model:
    Global objects larger than 'CodeModelLargeSize' bytes are placed in sections named with a trailing ".large"
    The folded global address into such objects are lowered into the const pool.
    During inspection it was noted that LowerConstantPool() was using a default offset of zero.
    A fix was made, but due to only offsets of zero being generated, testing only verifies the change is not detrimental.
    Fix explicitly specified sections flags.
    We assume the size of the object queried by getSectionForConstant() is never greater than CodeModelLargeSize.
    To handle greater than CodeModelLargeSize, changes to AsmPrinter would be required.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131128/637acb23/attachment.html>

More information about the llvm-commits mailing list