[PATCH] Adding TableGen patterns to auto-select TBM instructions

[Craig Topper]

I think the pattern that matches what the docs says since that's what a
user would be likely to write in C.

As far as the flags goes. We would need to do something if we wanted to
optimize for particular branch conditions after these instructions. Since
the flags are marked as Def on these instructions and no special code
exists in X86ISelLowering for these instruction the default behavior will
be to just not consume the flags at all.


On Tue, Oct 1, 2013 at 9:51 AM, Kay Tiong Khoo <kkhoo at perfwizard.com> wrote:

> Yes, the AMD doc (24594_APM_v3, Rev 3.20 May 2013, P. 91) says:
>
> "The BLCI instruction effectively performs a bit-wise logical or of the
> source operand and the inverse of the result of incrementing the source
> operand by 1, and stores the result to the destination register:
>
>    add tmp,  src, 1
>    not tmp,  tmp
>    or  dest, tmp, src"
>
>
> They also specify:
> "The value of the carry flag of rFLAGS is generated according to the
> result of the add pseudo- instruction and the remaining arithmetic flags
> are generated by the or pseudo-instruction."
>
> Does that need to be encoded in the definition somehow?
>
>
>
>
>
> On Mon, Sep 30, 2013 at 9:19 PM, Craig Topper <craig.topper at gmail.com>wrote:
>
>>
>>   While this probably mathematically correct.
>>
>>     def : Pat<(or GR32:$src, (sub -2, GR32:$src)),
>>               (BLCI_32rr GR32:$src)>;
>>     def : Pat<(or GR64:$src, (sub -2, GR64:$src)),
>>               (BLCI_64rr GR64:$src)>;
>>
>>   Don't the docs from AMD say something that would be  (or GR64:$src,
>> (not (add GR64:$src, 1)))?
>>
>> http://llvm-reviews.chandlerc.com/D1788
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131001/526d70e5/attachment.html>