[PATCH] [3/6] Add support for non-utf8 file names in Path.inc

Reid Kleckner rnk at google.com
Mon Sep 30 17:02:11 PDT 2013

On Mon, Sep 30, 2013 at 4:13 PM, David Majnemer <david.majnemer at gmail.com>wrote:

> On Mon, Sep 30, 2013 at 12:34 PM, Gao, Yunzhong <
> yunzhong_gao at playstation.sony.com> wrote:
>> Reid's suggestion (using wmain) does seem like a neat solution; it saves
>> one system-locale-to-unicode conversion.
>> I will experiment with this approach later this week to see how well it
>> goes.
>> I wonder whether the contents of a response file should be UTF8 or system
>> locale encoded?
>> - Gao.
> I have implemented a solution that allows mingw, cygwin and traditional
> win32 to allow for unicode based paths. It will be out for review this
> week.  It does not use 'wmain' because that approach has serious downsides:
> - Doesn't work at all for cygwin
> - Half works with mingw

I discussed using GetCommandLineW() and TokenizeWindowsCommandLine offline
with David.  This would also get the original, Unicode command line and
make it UTF-8, but it requires tokenizing a Windows command line, which we
already do for response files.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130930/41a1b007/attachment.html>

More information about the llvm-commits mailing list