[PATCH] [3/6] Add support for non-utf8 file names in Path.inc
david.majnemer at gmail.com
Mon Sep 30 16:13:14 PDT 2013
On Mon, Sep 30, 2013 at 12:34 PM, Gao, Yunzhong <
yunzhong_gao at playstation.sony.com> wrote:
> Reid's suggestion (using wmain) does seem like a neat solution; it saves
> one system-locale-to-unicode conversion.
> I will experiment with this approach later this week to see how well it
> I wonder whether the contents of a response file should be UTF8 or system
> locale encoded?
> - Gao.
I have implemented a solution that allows mingw, cygwin and traditional
win32 to allow for unicode based paths. It will be out for review this
week. It does not use 'wmain' because that approach has serious downsides:
- Doesn't work at all for cygwin
- Half works with mingw
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > bounces at cs.uiuc.edu] On Behalf Of Rafael Espíndola
> > Sent: Monday, September 30, 2013 12:15 PM
> > To: Reid Kleckner
> > Cc: Commit Messages and Patches for LLVM;
> > reviews+D1295+public+0bd57a4d645c744a at llvm-reviews.chandlerc.com
> > Subject: Re: [PATCH] [3/6] Add support for non-utf8 file names in
> > > Yes, probably the real solution is to define wmain instead of main, so
> > > we can get our hands on Unicode paths to start with, convert that to
> > > UTF-8 internally, and go from there.
> > Agreed. We really should not try guessing the encoding.
> > Cheers,
> > Rafael
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits