[PATCH] [3/6] Add support for non-utf8 file names in Path.inc

Richard Mitton richard at codersnotes.com
Mon Sep 30 17:12:23 PDT 2013


I haven't entirely been paying attention to the whole thread here, but 
is there a reason we don't just call CommandLineToArgvW and use that? 
Then we wouldn't have to write our own command line parser.

Richard Mitton
richard at codersnotes.com

On 09/30/2013 05:02 PM, Reid Kleckner wrote:
> On Mon, Sep 30, 2013 at 4:13 PM, David Majnemer 
> <david.majnemer at gmail.com <mailto:david.majnemer at gmail.com>> wrote:
>     On Mon, Sep 30, 2013 at 12:34 PM, Gao, Yunzhong
>     <yunzhong_gao at playstation.sony.com
>     <mailto:yunzhong_gao at playstation.sony.com>> wrote:
>         Reid's suggestion (using wmain) does seem like a neat
>         solution; it saves one system-locale-to-unicode conversion.
>         I will experiment with this approach later this week to see
>         how well it goes.
>         I wonder whether the contents of a response file should be
>         UTF8 or system locale encoded?
>         - Gao.
>     I have implemented a solution that allows mingw, cygwin and
>     traditional win32 to allow for unicode based paths. It will be out
>     for review this week.  It does not use 'wmain' because that
>     approach has serious downsides:
>     - Doesn't work at all for cygwin
>     - Half works with mingw
> I discussed using GetCommandLineW() and TokenizeWindowsCommandLine 
> offline with David.  This would also get the original, Unicode command 
> line and make it UTF-8, but it requires tokenizing a Windows command 
> line, which we already do for response files.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130930/03a0fd6e/attachment.html>

More information about the llvm-commits mailing list