[PATCH] Add non-blocking Wait() for launched processes

Reid Kleckner rnk at google.com
Fri Sep 27 15:02:06 PDT 2013

Comment at: include/llvm/Support/Program.h:38
@@ +37,3 @@
+#elif defined(LLVM_ON_WIN32)
+  typedef unsigned long ProcessId; // Must match the type of DWORD on Windows.
+  typedef void * HANDLE; // Must match the type of HANDLE on Windows.
Rafael Ávila de Espíndola wrote:
> maybe a silly question, but why not use DWORD and HANDLE instead of having these comments?
Please don't include all of windows.h in a header like Program.h that may be included widely in cross-platform code.  :)


More information about the llvm-commits mailing list