[PATCH] Add non-blocking Wait() for launched processes

[Rafael Avila de Espindola]

Ok

Sent from my iPhone

> On Sep 27, 2013, at 18:02, Reid Kleckner <rnk at google.com> wrote:
> 
> 
> 
> ================
> Comment at: include/llvm/Support/Program.h:38
> @@ +37,3 @@
> +#elif defined(LLVM_ON_WIN32)
> +  typedef unsigned long ProcessId; // Must match the type of DWORD on Windows.
> +  typedef void * HANDLE; // Must match the type of HANDLE on Windows.
> ----------------
> Rafael Ávila de Espíndola wrote:
>> maybe a silly question, but why not use DWORD and HANDLE instead of having these comments?
> Please don't include all of windows.h in a header like Program.h that may be included widely in cross-platform code.  :)
> 
> 
> http://llvm-reviews.chandlerc.com/D1728