[PATCH] Add non-blocking Wait() for launched processes

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Sep 27 12:35:53 PDT 2013

  LGTM with one nit.

Comment at: include/llvm/Support/Program.h:38
@@ +37,3 @@
+#elif defined(LLVM_ON_WIN32)
+  typedef unsigned long ProcessId; // Must match the type of DWORD on Windows.
+  typedef void * HANDLE; // Must match the type of HANDLE on Windows.
maybe a silly question, but why not use DWORD and HANDLE instead of having these comments?


More information about the llvm-commits mailing list