Fix PR 17372: Emitting PLD for stack prefetching on Thumb2

Tilmann Scheller tscheller at
Thu Sep 26 05:51:54 PDT 2013

Looks good to me!



On Sep 26, 2013, at 12:20 AM, Weiming Zhao <weimingz at> wrote:

> Hi,
> This patch fixes PR 17372:  Emitting PLD instructions for stack  address on ARM Thumb2.
>     negativeOffsetOpcode(), positiveOffsetOpcode()
>     and immediateOffsetOpcode() did not handle t2PLDi12, t2PLDi8 and
>     t2PLDs, so an opcode of 0 is returned, which causes compiler crash in
> debug build or missing PLD in release build.
> Please help to review it.
> Note: there is a separate bug for PLD on ARM mode. However, the existing test case (prefetch.ll) runs for both ARM and Thumb.
> After David fixes the ARM mode issue, this test case can be merged back to prefetch.ll.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> <0001-PR-17372-Emitting-PLD-for-stack-prefetching-on-Thumb.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the llvm-commits mailing list