[PATCH][MC/SPARC] Add support for EH to SPARC backend

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Sep 25 15:41:32 PDT 2013

Sorry for the slow review, I was on vacations.

>    Now. I split the patch into three patches.


>   First patch implements parsing and emitting .cfi_window_save and checks
> the binary output also. Second patch teaches AsmPrinter how to emit
> .cfi_register, which is required for implemening exceptionhandling for
> SPARC. The final patch implements ExceptionHandling support in sparc
> backend.
>   Originally I named EmitCFIGNUWIndowSave because the corresponding enum in
> llvm/Support/dwarf.h is DW_CFA_GNU_window_save. Now, I renamed the functions
> as CFIWindowSave to be consistent with the .cfi_window_save as suggested.
>   The EmitCFIWindowSave() and ParseCFIWindowSave() functions still start
> with uppercase letter to be consistent with other methods in the AsmStreamer
> and AsmParser class.

My preference would be to use the new naming convention, but that is fine.

The first patch is OK.  I will review the other two in a sec.

I got some conflicts when trying to apply the first patch. A resolved
one is attached for convenience.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 8289 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130925/f8a41e23/attachment.obj>

More information about the llvm-commits mailing list