Fix PR 17372: Emitting PLD for stack prefetching on Thumb2

[Renato Golin]

Hi Weiming,

Looks like a silly omission. Patch LGTM.

cheers,
--renato

On 25 September 2013 23:20, Weiming Zhao <weimingz at codeaurora.org> wrote:

> Hi,****
>
> ** **
>
> This patch fixes PR 17372:  Emitting PLD instructions for stack  address
> on ARM Thumb2. ****
>
>     negativeOffsetOpcode(), positiveOffsetOpcode()****
>
>     and immediateOffsetOpcode() did not handle t2PLDi12, t2PLDi8 and****
>
>     t2PLDs, so an opcode of 0 is returned, which causes compiler crash in*
> ***
>
> debug build or missing PLD in release build.****
>
> ** **
>
> Please help to review it.****
>
> ** **
>
> Note: there is a separate bug for PLD on ARM mode. However, the existing
> test case (prefetch.ll) runs for both ARM and Thumb. ****
>
> After David fixes the ARM mode issue, this test case can be merged back to
> prefetch.ll. ****
>
> ** **
>
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation****
>
> ** **
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130926/9086008f/attachment.html>