Fix PR 17372: Emitting PLD for stack prefetching on Thumb2

Weiming Zhao weimingz at codeaurora.org
Wed Sep 25 15:20:00 PDT 2013


Hi,

 

This patch fixes PR 17372:  Emitting PLD instructions for stack  address on
ARM Thumb2. 

    negativeOffsetOpcode(), positiveOffsetOpcode()

    and immediateOffsetOpcode() did not handle t2PLDi12, t2PLDi8 and

    t2PLDs, so an opcode of 0 is returned, which causes compiler crash in

debug build or missing PLD in release build.

 

Please help to review it.

 

Note: there is a separate bug for PLD on ARM mode. However, the existing
test case (prefetch.ll) runs for both ARM and Thumb. 

After David fixes the ARM mode issue, this test case can be merged back to
prefetch.ll. 

 

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130925/2e390afa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PR-17372-Emitting-PLD-for-stack-prefetching-on-Thumb.patch
Type: application/octet-stream
Size: 3485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130925/2e390afa/attachment.obj>


More information about the llvm-commits mailing list