<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>Hi,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>This patch fixes PR 17372: Emitting PLD instructions for stack address on ARM Thumb2. <o:p></o:p></p><p class=MsoNormal> negativeOffsetOpcode(), positiveOffsetOpcode()<o:p></o:p></p><p class=MsoNormal> and immediateOffsetOpcode() did not handle t2PLDi12, t2PLDi8 and<o:p></o:p></p><p class=MsoNormal> t2PLDs, so an opcode of 0 is returned, which causes compiler crash in<o:p></o:p></p><p class=MsoNormal style='text-indent:9.0pt'>debug build or missing PLD in release build.<o:p></o:p></p><p class=MsoNormal style='text-indent:9.0pt'><o:p> </o:p></p><p class=MsoNormal style='text-indent:9.0pt'>Please help to review it.<o:p></o:p></p><p class=MsoNormal style='text-indent:9.0pt'><o:p> </o:p></p><p class=MsoNormal style='text-indent:9.0pt'>Note: there is a separate bug for PLD on ARM mode. However, the existing test case (prefetch.ll) runs for both ARM and Thumb. <o:p></o:p></p><p class=MsoNormal style='text-indent:9.0pt'>After David fixes the ARM mode issue, this test case can be merged back to prefetch.ll. <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>