[PATCH] ARM FastISel fix sext/zext fold

Chad Rosier mcrosier at apple.com
Mon Jun 10 10:20:11 PDT 2013


Thanks. Feel free to commit.

On Jun 10, 2013, at 10:04 AM, JF Bastien <jfb at google.com> wrote:

> Thanks for the review Chad.
>  
>> The for loop should be written as:
>> 
>> for (unsigned i = 0, e = sizeof(FoldableExtends) / sizeof(FoldableExtends[0]); i < e; ++i) {
>>  . . .
>> }
> 
> Updated in attached patch.
>  
>> Are there existing test cases that exercise this code?  If not, please add the necessary test cases.
> 
> Yes: test/CodeGen/ARM/fast-isel-fold.ll
> The reason the test isn't failing is that FastISel isn't actually enabled for the tested target. I'll re-send my patch that enables FastISel for more targets soon.
>  
>> Otherwise, LGTM.
> <fastisel-fix-ext-fold.patch>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130610/6a4fcbae/attachment.html>


More information about the llvm-commits mailing list