<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Thanks. Feel free to commit.</div><div><br>On Jun 10, 2013, at 10:04 AM, JF Bastien <<a href="mailto:jfb@google.com">jfb@google.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Thanks for the review Chad.<br><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>The for loop should be written as:</div><div><br></div><div><div>for (unsigned i = 0, e = sizeof(FoldableExtends) / sizeof(FoldableExtends[0]); i < e; ++i) {</div></div><div> . . .</div>
<div>}</div></div></blockquote><div><br></div><div style="">Updated in attached patch.</div><div style=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>Are there existing test cases that exercise this code? If not, please add the necessary test cases.</div></div></blockquote><div><br></div><div style="">Yes: test/CodeGen/ARM/fast-isel-fold.ll</div>
<div style="">The reason the test isn't failing is that FastISel isn't actually enabled for the tested target. I'll re-send my patch that enables FastISel for more targets soon.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>Otherwise, LGTM.</div></div></blockquote></div></div></div>
</div></blockquote><blockquote type="cite"><div><fastisel-fix-ext-fold.patch></div></blockquote></body></html>