[PATCH] ARM FastISel fix sext/zext fold

JF Bastien jfb at google.com
Mon Jun 10 10:04:28 PDT 2013


Thanks for the review Chad.


> The for loop should be written as:
>
> for (unsigned i = 0, e = sizeof(FoldableExtends) /
> sizeof(FoldableExtends[0]); i < e; ++i) {
>  . . .
> }
>

Updated in attached patch.


> Are there existing test cases that exercise this code?  If not, please add
> the necessary test cases.
>

Yes: test/CodeGen/ARM/fast-isel-fold.ll
The reason the test isn't failing is that FastISel isn't actually enabled
for the tested target. I'll re-send my patch that enables FastISel for more
targets soon.


> Otherwise, LGTM.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130610/5f082079/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fastisel-fix-ext-fold.patch
Type: application/octet-stream
Size: 1954 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130610/5f082079/attachment.obj>


More information about the llvm-commits mailing list