[llvm] r174808 - [NVPTX] Make address space errors more explicit (llvm_unreachable -> report_fatal_error)

[Justin Holewinski]

On Sat, Feb 9, 2013 at 4:43 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
> On Feb 9, 2013 5:36 AM, "Justin Holewinski" <jholewinski at nvidia.com>
> wrote:
> >
> > Author: jholewinski
> > Date: Sat Feb  9 07:34:15 2013
> > New Revision: 174808
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=174808&view=rev
> > Log:
> > [NVPTX] Make address space errors more explicit (llvm_unreachable ->
> report_fatal_error)
> >
> > Modified:
> >     llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
> >
> > Modified: llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp?rev=174808&r1=174807&r2=174808&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp (original)
> > +++ llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp Sat Feb  9 07:34:15
> 2013
> > @@ -1314,7 +1314,8 @@ void NVPTXAsmPrinter::emitPTXAddressSpac
> >      O << "shared" ;
> >      break;
> >    default:
> > -    llvm_unreachable("unexpected address space");
> > +    report_fatal_error("Bad address space found while emitting PTX");
> > +    break;
>
> Is report_fatal_error not noreturn?
>

If the compiler supports it, sure.  Why do you ask?


> >    }
> >  }
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 

Thanks,

Justin Holewinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130209/84e58b64/attachment.html>