<div dir="ltr">On Sat, Feb 9, 2013 at 4:43 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><p dir="ltr"><br>
On Feb 9, 2013 5:36 AM, "Justin Holewinski" <<a href="mailto:jholewinski@nvidia.com" target="_blank">jholewinski@nvidia.com</a>> wrote:<br>
><br>
> Author: jholewinski<br>
> Date: Sat Feb  9 07:34:15 2013<br>
> New Revision: 174808<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=174808&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=174808&view=rev</a><br>
> Log:<br>
> [NVPTX] Make address space errors more explicit (llvm_unreachable -> report_fatal_error)<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp?rev=174808&r1=174807&r2=174808&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp?rev=174808&r1=174807&r2=174808&view=diff</a><br>


> ==============================================================================<br>
> --- llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp (original)<br>
> +++ llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp Sat Feb  9 07:34:15 2013<br>
> @@ -1314,7 +1314,8 @@ void NVPTXAsmPrinter::emitPTXAddressSpac<br>
>      O << "shared" ;<br>
>      break;<br>
>    default:<br>
> -    llvm_unreachable("unexpected address space");<br>
> +    report_fatal_error("Bad address space found while emitting PTX");<br>
> +    break;</p>
</div><p dir="ltr">Is report_fatal_error not noreturn?</p></blockquote><div><br></div><div style>If the compiler supports it, sure.  Why do you ask?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">
<p dir="ltr">>    }<br>
>  }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><br><div>Thanks,</div><div><br></div><div>Justin Holewinski</div>
</div></div>