[llvm] r174808 - [NVPTX] Make address space errors more explicit (llvm_unreachable -> report_fatal_error)

David Blaikie dblaikie at gmail.com
Sat Feb 9 13:43:51 PST 2013


On Feb 9, 2013 5:36 AM, "Justin Holewinski" <jholewinski at nvidia.com> wrote:
>
> Author: jholewinski
> Date: Sat Feb  9 07:34:15 2013
> New Revision: 174808
>
> URL: http://llvm.org/viewvc/llvm-project?rev=174808&view=rev
> Log:
> [NVPTX] Make address space errors more explicit (llvm_unreachable ->
report_fatal_error)
>
> Modified:
>     llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
>
> Modified: llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
> URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp?rev=174808&r1=174807&r2=174808&view=diff
>
==============================================================================
> --- llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/NVPTX/NVPTXAsmPrinter.cpp Sat Feb  9 07:34:15
2013
> @@ -1314,7 +1314,8 @@ void NVPTXAsmPrinter::emitPTXAddressSpac
>      O << "shared" ;
>      break;
>    default:
> -    llvm_unreachable("unexpected address space");
> +    report_fatal_error("Bad address space found while emitting PTX");
> +    break;

Is report_fatal_error not noreturn?

>    }
>  }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130209/2f62eea8/attachment.html>


More information about the llvm-commits mailing list