[llvm-bugs] [Bug 45933] New: [AssumeBundles] Missing AU.addRequired() call

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=45933

            Bug ID: 45933
           Summary: [AssumeBundles]  Missing AU.addRequired() call
           Product: libraries
           Version: 10.0
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Transformation Utilities
          Assignee: unassignedbugs at nondot.org
          Reporter: paulsson at linux.vnet.ibm.com
                CC: llvm-bugs at lists.llvm.org

It seems that the AssumeSimplify pass calls
getAnalysis<AssumptionCacheTracker>() without requiring it, and I get:

clang ~/tmp/test.c -save-temps -c -S -O3 -mllvm -enable-knowledge-retention

PassAnalysisSupport.h:236:
Assertion `ResultPass && "getAnalysis*() called on an analysis that was not "
"'required' by pass!"' failed

Is the following one-line patch good?

diff --git a/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
b/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
index ee5e142..631661a 100644
--- a/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
+++ b/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
@@ -467,6 +467,7 @@ public:

   void getAnalysisUsage(AnalysisUsage &AU) const override {
     AU.setPreservesAll();
+    AU.addRequired<AssumptionCacheTracker>();
   }
 };

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200515/1f2f1ffa/attachment.html>