<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [AssumeBundles] Missing AU.addRequired() call"
href="https://bugs.llvm.org/show_bug.cgi?id=45933">45933</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[AssumeBundles] Missing AU.addRequired() call
</td>
</tr>
<tr>
<th>Product</th>
<td>libraries
</td>
</tr>
<tr>
<th>Version</th>
<td>10.0
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>Transformation Utilities
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>paulsson@linux.vnet.ibm.com
</td>
</tr>
<tr>
<th>CC</th>
<td>llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>It seems that the AssumeSimplify pass calls
getAnalysis<AssumptionCacheTracker>() without requiring it, and I get:
clang ~/tmp/test.c -save-temps -c -S -O3 -mllvm -enable-knowledge-retention
PassAnalysisSupport.h:236:
Assertion `ResultPass && "getAnalysis*() called on an analysis that was not "
"'required' by pass!"' failed
Is the following one-line patch good?
diff --git a/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
b/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
index ee5e142..631661a 100644
--- a/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
+++ b/llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
@@ -467,6 +467,7 @@ public:
void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.setPreservesAll();
+ AU.addRequired<AssumptionCacheTracker>();
}
};</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>