[llvm-bugs] [Bug 46997] New: lint applies in clang test directory and silently breaks things

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=46997

            Bug ID: 46997
           Summary: lint applies in clang test directory and silently
                    breaks things
           Product: Phabricator
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: All Bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: richard-llvm at metafoo.co.uk
                CC: llvm-bugs at lists.llvm.org

arc diff applies lint to the source code, in particular running clang-format.
In the case where this applies to the actual code, we're prompted whether to
accept the changes. That's OK, except when the changes are bad, as they usually
are when clang-format was already used while editing -- any deviations from the
clang-format formatting are in that case intentional.

But arc diff *also* applies clang-format to Clang's test/ directory,
reformatting files whose format is both important and not intended to match any
particular coding style. Such changes can break the test, either subtly or
blatantly. And as if that wasn't bad enough, such changes appear to be applied
automatically, without prompting, and are by default amended to the head
commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200805/cbd95c32/attachment.html>