<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - lint applies in clang test directory and silently breaks things"
href="https://bugs.llvm.org/show_bug.cgi?id=46997">46997</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>lint applies in clang test directory and silently breaks things
</td>
</tr>
<tr>
<th>Product</th>
<td>Phabricator
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>All Bugs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>richard-llvm@metafoo.co.uk
</td>
</tr>
<tr>
<th>CC</th>
<td>llvm-bugs@lists.llvm.org
</td>
</tr></table>
<p>
<div>
<pre>arc diff applies lint to the source code, in particular running clang-format.
In the case where this applies to the actual code, we're prompted whether to
accept the changes. That's OK, except when the changes are bad, as they usually
are when clang-format was already used while editing -- any deviations from the
clang-format formatting are in that case intentional.
But arc diff *also* applies clang-format to Clang's test/ directory,
reformatting files whose format is both important and not intended to match any
particular coding style. Such changes can break the test, either subtly or
blatantly. And as if that wasn't bad enough, such changes appear to be applied
automatically, without prompting, and are by default amended to the head
commit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>