[lldb-dev] something just toasted the test suite on OS X
Todd Fiala via lldb-dev
lldb-dev at lists.llvm.org
Mon Jan 25 20:25:04 PST 2016
Well our whole test suite just stopped running, so yes.
On Mon, Jan 25, 2016 at 6:58 PM, Enrico Granata <egranata at apple.com> wrote:
> On Jan 25, 2016, at 6:48 PM, Todd Fiala via lldb-dev <
> lldb-dev at lists.llvm.org> wrote:
> Not sure exactly what it is, but all the tests are failing due to some bad
> assumptions of unicode vs. str on Python 2 vs. 3 if I had to guess.
> Author: zturner
> Date: Mon Jan 25 18:59:42 2016
> New Revision: 258759
> URL: http://llvm.org/viewvc/llvm-project?rev=258759&view=rev
> Write the session log file in UTF-8.
> Previously we were writing in the default encoding, which depends
> on the operating system and is not guaranteed to be unicode aware.
> On Python 3, this would lead to a situation where writing unicode
> text to the log file generates an exception. The fix here is to
> write session logs using the proper encoding, which incidentally
> fixes another test, so xfail is removed from that.
> sounds like a likely culprit from what you’re saying
> I am not going to be able to look at details on that, but here's a link to
> the log on the OS X builder:
> Do you want me to revert?
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
> *- Enrico*
> 📩 egranata@.com ☎️ 27683
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-dev