[libcxx-commits] [PATCH] D59678: Make common_type's implementation common
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 21 18:27:49 PDT 2019
EricWF marked 2 inline comments as done.
EricWF added inline comments.
Comment at: test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:327
+#if TEST_STD_VER >= 11
+ // Test that we're really variadic in C++11
> Any reason not to use `ASSERT_SAME_TYPE` in these tests? I find it much easier to read.
Not really, I was just going with the existing style of the file. Normally I try to write `ASSERT_SAME_TYPE` as well.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits