[libcxx-commits] [PATCH] D59678: Make common_type's implementation common

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 21 18:25:00 PDT 2019


mclow.lists added inline comments.


================
Comment at: test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:327
 
+#if TEST_STD_VER >= 11
+    // Test that we're really variadic in C++11
----------------
Any reason not to use `ASSERT_SAME_TYPE` in these tests? I find it much easier to read.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59678/new/

https://reviews.llvm.org/D59678





More information about the libcxx-commits mailing list