[libcxx-commits] [PATCH] D59678: Make common_type's implementation common

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 21 19:35:51 PDT 2019


ldionne added inline comments.


================
Comment at: include/type_traits:2189
+    : conditional<
+        is_same<_Tp, typename decay<_Tp>::type>::value && is_same<_Up, typename decay<_Up>::type>::value,
+        __common_type2_imp<_Tp, _Up>,
----------------
If one is already decayed but the other isn't, shouldn't you decay the one that isn't?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59678/new/

https://reviews.llvm.org/D59678





More information about the libcxx-commits mailing list