[cfe-dev] [PATCH] Fix clang test failures on MIPS

Simon Atanasyan satanasyan at mips.com
Tue May 8 13:30:20 PDT 2012

On Tue, May 8, 2012 at 4:08 PM, Manuel Klimek <klimek at google.com> wrote:
> - I'd rather have us always install a ClangSyntaxOnlyAdjuster by
> default in ClangTool; I have experience with the variant that requires
> tools to add it always, and then you basically have 99% of the tools
> adding the syntax only adjuster, which seems like a waste
> - I'd also require an ArgumentsAdjuster to be set; not modifying the
> arguments is actually an unexpected use case - for running stuff next
> to a compile, we should encourage the use of clang-plugins :)
> - just adding -fsyntax-only is not enough, we'll also need to weed out
> options that generate output (I have some stuff ready, I'm happy to
> put that in later if you want to add a FIXME)
> - there's a lost looking empty FIXME next to the ArgsAdjuster member...

Thanks for the comments. New patch is attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: adjusters2.patch
Type: application/octet-stream
Size: 6834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20120509/c5a3f4e5/attachment.obj>

More information about the cfe-dev mailing list