[cfe-dev] [PATCH] Fix clang test failures on MIPS

Manuel Klimek klimek at google.com
Tue May 8 05:08:06 PDT 2012

On Tue, May 8, 2012 at 1:09 PM, Simon Atanasyan <satanasyan at mips.com> wrote:
> Hi,
> On Sat, May 5, 2012 at 12:30 AM, Manuel Klimek <klimek at google.com> wrote:
>> On Fri, May 4, 2012 at 9:56 PM, Simon Atanasyan <satanasyan at mips.com> wrote:
>>> Now I see your point and like this approach. I will implement and send
>>> a patch for review.
>> Thx! Looking forward to it :)
> The patch is attached. Please review it.

Some thoughts:
- I'd rather have us always install a ClangSyntaxOnlyAdjuster by
default in ClangTool; I have experience with the variant that requires
tools to add it always, and then you basically have 99% of the tools
adding the syntax only adjuster, which seems like a waste
- I'd also require an ArgumentsAdjuster to be set; not modifying the
arguments is actually an unexpected use case - for running stuff next
to a compile, we should encourage the use of clang-plugins :)
- just adding -fsyntax-only is not enough, we'll also need to weed out
options that generate output (I have some stuff ready, I'm happy to
put that in later if you want to add a FIXME)
- there's a lost looking empty FIXME next to the ArgsAdjuster member...

Thanks for working on this!

More information about the cfe-dev mailing list