[cfe-dev] [PATCH] Fix clang test failures on MIPS

Manuel Klimek klimek at google.com
Tue May 8 14:06:35 PDT 2012

On Tue, May 8, 2012 at 10:30 PM, Simon Atanasyan <satanasyan at mips.com> wrote:
> On Tue, May 8, 2012 at 4:08 PM, Manuel Klimek <klimek at google.com> wrote:
>> - I'd rather have us always install a ClangSyntaxOnlyAdjuster by
>> default in ClangTool; I have experience with the variant that requires
>> tools to add it always, and then you basically have 99% of the tools
>> adding the syntax only adjuster, which seems like a waste
>> - I'd also require an ArgumentsAdjuster to be set; not modifying the
>> arguments is actually an unexpected use case - for running stuff next
>> to a compile, we should encourage the use of clang-plugins :)
>> - just adding -fsyntax-only is not enough, we'll also need to weed out
>> options that generate output (I have some stuff ready, I'm happy to
>> put that in later if you want to add a FIXME)
>> - there's a lost looking empty FIXME next to the ArgsAdjuster member...
> Thanks for the comments. New patch is attached.

Generally looks good now, two more things to consider:
1. I think we should add a comment about the default setting for the
adjuster in the ClangTool class comment
2. How do we test this? I assume all tests still run with
-fsynatx-only; I'm not sure whether there's a good way to make sure
that code generation has not been run, apart from basically making the
output directory unwritable; I'm also fine with letting this in as is,
and adding tests when we add more adjustments...


More information about the cfe-dev mailing list