[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 25 07:25:02 PST 2021


HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/Format.cpp:3274
+  llvm::SmallVector<std::string, 2> FilesToLookFor;
+  // User provided clang-format file using -style=file:/path/to/format/file
+  // Check for explicit config filename
----------------
MyDeveloperDay wrote:
> part of me wonders if this format should be
> 
> `file://<path>` rather than `file:<path>`
> 
> ```User provided clang-format file using -style=file:///path/to/format/file```
> 
> vs
> 
> ```User provided clang-format file using -style=file:/path/to/format/file```
> 
> This would leave the way open to other protocols http:// or https:// or anything else.
Maybe, but I doubt we want http. And if we use `file://` a windows path `D:\Path\` would not be valid, would it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72326/new/

https://reviews.llvm.org/D72326



More information about the cfe-commits mailing list