[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 07:39:15 PDT 2020


Szelethus added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1226
+            TStream.injextRange(
+                const_cast<MacroParamMap &>(PrevParamMap)[__VA_ARGS__II]);
+            TStream.next(TheTok);
----------------
Oh, this has to be fixed as well. `at()` should be fine, we messed something up really bad if the information we gathered from containing macro has no mention of `__VA_ARGS__`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86135/new/

https://reviews.llvm.org/D86135



More information about the cfe-commits mailing list