[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

Bevin Hansson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 05:51:25 PDT 2020


ebevhan added a comment.

It doesn't feel like this patch got a very positive reception, but I'd still like to try a bit more to get it in.

Even though it's difficult to test this particular change upstream, would it still be acceptable to take the patch since it reverts the behavior to what it was previously? If there are worries that things may break in the future due to other changes, we do catch these things in our downstream testing and are fairly diligent about reporting back about them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85191/new/

https://reviews.llvm.org/D85191



More information about the cfe-commits mailing list