[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

Dimitry Andric via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 31 06:12:50 PDT 2020


dim added a comment.

In D77776#2187334 <https://reviews.llvm.org/D77776#2187334>, @myfreeweb wrote:

> In D77776#2187273 <https://reviews.llvm.org/D77776#2187273>, @dim wrote:
>
>>>   +#ifdef __FreeBSD__
>>>   +	  return __FreeBSD_version / 100000;
>>>   +#else
>>>   +	  return 10;
>>>   +#endif
>>
>> No, that would hardcode something at build time. We need to respect whatever triple the user is passing in.
>
> Nobody has proposed not respecting that, this is all in the context of the `if (Major == 0)` fallback

Aha, then there is no need to do arithmetic with `__FreeBSD_version`, as `__FreeBSD__` already contains just the major version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77776/new/

https://reviews.llvm.org/D77776



More information about the cfe-commits mailing list