[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

Greg V via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 31 06:10:12 PDT 2020


myfreeweb added a comment.

In D77776#2187273 <https://reviews.llvm.org/D77776#2187273>, @dim wrote:

>>   +#ifdef __FreeBSD__
>>   +	  return __FreeBSD_version / 100000;
>>   +#else
>>   +	  return 10;
>>   +#endif
>
> No, that would hardcode something at build time. We need to respect whatever triple the user is passing in.

Nobody has proposed not respecting that, this is all in the context of the `if (Major == 0)` fallback


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77776/new/

https://reviews.llvm.org/D77776



More information about the cfe-commits mailing list