[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

[Nathan James via Phabricator via cfe-commits]

njames93 marked 2 inline comments as done.
njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:109
         SourceMgr(Diags, Files), Context(Context), ApplyFixes(ApplyFixes),
-        TotalFixes(0), AppliedFixes(0), WarningsAsErrors(0) {
+        ApplyAnyFix(ApplyAnyFix), TotalFixes(0), AppliedFixes(0),
+        WarningsAsErrors(0) {
----------------
Eugene.Zelenko wrote:
> It'll be reasonable to use member initialization for `TotalFixes`, `AppliedFixes`, `WarningsAsErrors`.
It would be, but that's a refactoring change unrelated to this patch


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:252
       RemoveIncompatibleErrors(RemoveIncompatibleErrors),
-      LastErrorRelatesToUserCode(false), LastErrorPassesLineFilter(false),
-      LastErrorWasIgnored(false) {}
+      FindAnyFixIt(FindAnyFixit), LastErrorRelatesToUserCode(false),
+      LastErrorPassesLineFilter(false), LastErrorWasIgnored(false) {}
----------------
Eugene.Zelenko wrote:
> It'll be reasonable to use member initialization for `LastErrorRelatesToUserCode`, `LastErrorPassesLineFilter`, `LastErrorWasIgnored`.
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84924/new/

https://reviews.llvm.org/D84924