[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 30 09:06:35 PDT 2020


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:109
         SourceMgr(Diags, Files), Context(Context), ApplyFixes(ApplyFixes),
-        TotalFixes(0), AppliedFixes(0), WarningsAsErrors(0) {
+        ApplyAnyFix(ApplyAnyFix), TotalFixes(0), AppliedFixes(0),
+        WarningsAsErrors(0) {
----------------
It'll be reasonable to use member initialization for `TotalFixes`, `AppliedFixes`, `WarningsAsErrors`.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:252
       RemoveIncompatibleErrors(RemoveIncompatibleErrors),
-      LastErrorRelatesToUserCode(false), LastErrorPassesLineFilter(false),
-      LastErrorWasIgnored(false) {}
+      FindAnyFixIt(FindAnyFixit), LastErrorRelatesToUserCode(false),
+      LastErrorPassesLineFilter(false), LastErrorWasIgnored(false) {}
----------------
It'll be reasonable to use member initialization for `LastErrorRelatesToUserCode`, `LastErrorPassesLineFilter`, `LastErrorWasIgnored`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84924/new/

https://reviews.llvm.org/D84924



More information about the cfe-commits mailing list