[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added a comment.

We probably do want a macro to indicate 'compiling for amdgcn as the device half of a combined host+device language'. I'm having a tough time with the control flow in this header so we probably want tests to check the overall behaviour is as intended. E.g. static assert + various language modes.

The header should be obviously implemention only so we can change it later. Maybe also provide an unset header and keep them out of application scope entirely to begin with. That's the advantage over the otherwise simpler design of clang always setting them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84743/new/

https://reviews.llvm.org/D84743