[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 28 23:23:35 PDT 2020


jdoerfert added inline comments.


================
Comment at: clang/lib/Headers/offload_macros.h:1
+//===--- offload_macros.h - Universal _DEVICE Offloading Macros Header ---===//
+//
----------------
After @MaskRay noticed this, I think this should be `__offload_macros.h` to make it clear this is an internal header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84743/new/

https://reviews.llvm.org/D84743



More information about the cfe-commits mailing list