[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

Logan Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 22 12:00:46 PDT 2020


logan-5 added a comment.

Thanks for reverting--I agree that that's the right move at this point.

Pretty much totally out my depth here, and I don't have a way of debugging the Windows issue, so I'm not sure how to proceed. I'm tempted to just let this whole thing rest for now and maybe try again sometime in the future.

I didn't realize quite how much I was biting off by volunteering to do this. I want to apologize again for all the trouble.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84244/new/

https://reviews.llvm.org/D84244





More information about the cfe-commits mailing list