[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

Wed Jul 22 11:26:16 PDT 2020

hans added inline comments.

================
Comment at: clang/unittests/CMakeLists.txt:14
+if (CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG)
+  add_definitions("-Wno-suggest-override")
+endif()
----------------
Because it's added as a define, this gets passed to rc.exe in Windows builds, which is used for some clang-tools-extra unittest target, which then proceeds to fail with:

 fatal error RC1106: invalid option: -o-suggest-override

(See e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874065661026292624/+/steps/package_clang/0/stdout)

I don't know why this doesn't happen to other flags, but I think there's been enough fallout from this now that it should be reverted while that's figured out. Reverting in 3eec65782575a1284391e447142fd004dd5de4a9.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84244/new/

https://reviews.llvm.org/D84244