[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

Wed Jul 15 05:44:24 PDT 2020

ABataev added a comment.

In D83863#2153021 <https://reviews.llvm.org/D83863#2153021>, @saiislam wrote:

> In D83863#2153008 <https://reviews.llvm.org/D83863#2153008>, @ABataev wrote:
>
> > Not sure that this is really required. If we want to check for the default version, it would be good to check that it still works for 4.5. It means, need to add additional RUN lines. But I don't think it is profitable to test the same functionality several times without actual effect
>
>
> These 67 files were testing only for version 4.5. As the default version is now 5.0, isn't it expected that the tests run against it?

It just means that there are no changes in functionality between 4.5 and 5.0. Sure, you can switch to the default version instead but I don't see real profit here. Anyway, it is up to you.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83863/new/

https://reviews.llvm.org/D83863