[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

Saiyedul Islam via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 15 05:42:12 PDT 2020


saiislam added a comment.

In D83863#2153008 <https://reviews.llvm.org/D83863#2153008>, @ABataev wrote:

> Not sure that this is really required. If we want to check for the default version, it would be good to check that it still works for 4.5. It means, need to add additional RUN lines. But I don't think it is profitable to test the same functionality several times without actual effect


These 67 files were testing only for version 4.5. As the default version is now 5.0, isn't it expected that the tests run against it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83863/new/

https://reviews.llvm.org/D83863





More information about the cfe-commits mailing list