[PATCH] D83536: [clangd] Index refs to main-file symbols as well

Fri Jul 10 08:42:42 PDT 2020

nridge added a comment.

In D83536#2143436 <https://reviews.llvm.org/D83536#2143436>, @kadircet wrote:

> I can see how this is needed for implementing the full protocol though (we've already cut on the multi-level callees support), so would you be so kind to hide this behind an option to symbol collector (`CollectRefsInMainFile`) and then introduce a flag to clangd for controlling it `--collect-refs-in-main-file` and plumb it to `BackgroundIndex` and `FileIndex` via `ClangdServer`?

I can do that.

Another thing we could consider, if the space increase is a concern, is to limit which references we store, e.g. to functions only (not variables or classes).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83536/new/

https://reviews.llvm.org/D83536