[PATCH] D83536: [clangd] Index refs to main-file symbols as well

Fri Jul 10 01:29:09 PDT 2020

kadircet added a comment.

Thanks a lot for doing this Nathan and sorry for not replying with a concrete decision on the issue tracker, we were still discussing it internally, as 7% increase for allowing multi-level call hierarchy support (compared to ~10% initial cost for single-level support) seems quite high. Especially right before a new llvm release cut (which is due in 5 days).

I can see how this is needed for implementing the full protocol though (we've already cut on the multi-level callees support), so would you be so kind to hide this behind an option to symbol collector (`CollectRefsInMainFile`) and then introduce a flag to clangd for controlling it `--collect-refs-in-main-file` and plumb it to `BackgroundIndex` and `FileIndex` via `ClangdServer`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83536/new/

https://reviews.llvm.org/D83536