[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

Sat Jul 4 14:30:39 PDT 2020

njames93 marked an inline comment as done.
njames93 added inline comments.

================
Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:225

+// FIXME: Figure out why this test causes crashes on mac os.
+#ifndef __APPLE__
----------------
@aaron.ballman @thakis I figured out a way to prevent the test cases failing on mac, still can't figure out the root cause. Would this be acceptable for now?

As far as I can see some subtle linker bug in the default mac os linker isn't happy when this test case is included. This actual test case runs just fine, but the test in ClangTidyDiagnosticsConsumerTest doesn't run properly. It appears to instantiate the context and then instantiate the check, but it never attempts to register it, causing the whole test case to fail.
clang-tidy builds just fine which has many uses of this new enum handling and check-clang-tools also runs without a hitch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82188/new/

https://reviews.llvm.org/D82188