[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

Mon Jun 29 10:49:26 PDT 2020

njames93 added a comment.

In D82188#2119980 <https://reviews.llvm.org/D82188#2119980>, @thakis wrote:

> In this case, trunk was broken for > 12h, so I'd expect there's lots of evidence of this being broken on cmake bots too. However, the mac bots aren't on buildbot but on http://green.lab.llvm.org/green/ for whatever reason, and I find that page hard to read. http://green.lab.llvm.org/green/job/clang-stage1-RA/ has a bunch of red on the LHS … ah yeah http://green.lab.llvm.org/green/job/clang-stage1-RA/11966/console has "  Extra Tools Unit Tests :: clang-tidy/./ClangTidyTests/ClangTidyDiagnosticConsumer.SortsErrors" at the bottom.
>
> So this showed up on the regular mac bots, yes.
>
>  ---
>
> The tree's been broken for over half a day to this. I'd suggest taking breakage supports a bit more serious going forward, instead of replying with "it can't possibly be this patch" and "it must be bot setup weirdness" going forward :)

Thanks for clarifying about the regular mac bots. Is this isolated to just mac bots?

If it is isolated then the logical reason for this failure would be a subtle bug in the host toolchain. 
When I landed for a second time, I noticed that the `TestCheck` in `ClangTidyDiagnosticsConsumerTest.cpp` gets instantiated, but the `registerMatchers` function never gets called, this is the root cause for why the test fails.
However you just need to read the the code to see how that situation shouldn't happen.
Without a mac to test on, I wont be able to investigate further(no pre merge mac test bot also makes this significantly harder for me to test), Tried testing on older clang compiler and wasn't able to reproduce any error.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82188/new/

https://reviews.llvm.org/D82188