[PATCH] D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch

Greg Rodgers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 30 10:49:59 PDT 2020


gregrodgers added a comment.

This was discussed on llvm-dev three years ago.  Here is the thread.

http://lists.llvm.org/pipermail/llvm-dev/2017-February/109930.html

The last name discussed was "-- offload-arch".   I don't believe we need a list option anymore.   So ignore the very old request for --offload-archs.

I am ok with the patch the way it is.   In the future, we should consider renaming the CudaArch class to OffloadArch class .  Also the GpuArchList is currently only initialized in CudaActionBuilder.   Eventually this is will have to be done for HIPActionBuilder and OpenMPActionBuilder.   Could you consider creating a function to  InitializeGpuArchList ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76987/new/

https://reviews.llvm.org/D76987





More information about the cfe-commits mailing list